Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Making the moment lib global in ArgoCD project to minimize the tar ball of metrics extension #13075

Merged
merged 6 commits into from
Mar 31, 2023

Conversation

schakrad
Copy link
Contributor

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

Please see Contribution FAQs if you have questions about your pull-request.

schakrad and others added 6 commits December 13, 2022 17:13
…pplicationListView.

Signed-off-by: schakradari <saisindhu_chakradari@intuit.com>
…pplicationListView.

Signed-off-by: schakradari <saisindhu_chakradari@intuit.com>
Signed-off-by: schakrad <chakradari.sindhu@gmail.com>
@crenshaw-dev crenshaw-dev changed the title feat: Making the moment lib global in ArgoCD project to minimize the tar ball of metrics extension. feat: Making the moment lib global in ArgoCD project to minimize the tar ball of metrics extension Mar 31, 2023
@crenshaw-dev crenshaw-dev enabled auto-merge (squash) March 31, 2023 20:22
@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

Patch coverage has no change and project coverage change: +1.24 🎉

Comparison is base (6971966) 47.78% compared to head (a980926) 49.03%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #13075      +/-   ##
==========================================
+ Coverage   47.78%   49.03%   +1.24%     
==========================================
  Files         246      246              
  Lines       41944    42519     +575     
==========================================
+ Hits        20045    20849     +804     
+ Misses      19898    19558     -340     
- Partials     2001     2112     +111     

see 45 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@crenshaw-dev crenshaw-dev merged commit f5d343f into argoproj:master Mar 31, 2023
yyzxw pushed a commit to yyzxw/argo-cd that referenced this pull request Aug 9, 2023
…tar ball of metrics extension (argoproj#13075)

* argoproj#11602 fix : Object options menu truncated when selected in ApplicationListView.

Signed-off-by: schakradari <saisindhu_chakradari@intuit.com>

* argoproj#11602 fix : Object options menu truncated when selected in ApplicationListView.

Signed-off-by: schakradari <saisindhu_chakradari@intuit.com>

* metrics-extension-change

Signed-off-by: schakrad <chakradari.sindhu@gmail.com>

---------

Signed-off-by: schakradari <saisindhu_chakradari@intuit.com>
Signed-off-by: schakrad <chakradari.sindhu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants